[mlir][mesh]

Open Beginner friendly
#116,188 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
62/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp
Domain
compilers

Research direction

Open mlir/lib/Dialect/Mesh/Transforms/Spmdization.cpp at line 98 and inspect the surrounding use of allReduceMeshAxes. Determine whether the variable should be named remainingPartialAxes as suggested, then verify that the rename is consistent in the surrounding code.

Written by the indexing model from the issue text.

Description

mlir:mesh

https://github.com/llvm/llvm-project/blob/e52238b59f250aef5dc0925866d0308305a19dbf/mlir/lib/Dialect/Mesh/Transforms/Spmdization.cpp#L98
It should probably be "remainingPartialAxes" instead of "allReduceMeshAxes" here？
image

Dominant language
LLVM
Stars
40.6k
Forks
18.7k
Avg merge
18h 16m
Merged PRs (30d)
417

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from llvm/llvm-project

All issues in llvm/llvm-project

Similar issues

More Compilers issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.