llvm/llvm-project

[clang-analyzer-security.insecureAPI.strcpy] extend list of unsafe functions

Open

#103,038 opened on Aug 13, 2024

View on GitHub
 (16 comments) (0 reactions) (0 assignees)C++ (10,782 forks)batch import
clang:static analyzergood first issue

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description

Hi,

it would be nice, if the list of functions, that are marked as unsafe would be extensible or include i.e. the following (under windows and atl/mfc microsoft propietary stuff)

  • _strcpy
  • _strdup
  • _strcat
  • _tcscpy
  • _tcscat
  • _tcsdup
  • lstrcpy
  • lstrcat
  • strncpy
  • strncat

Check: https://clang.llvm.org/docs/analyzer/checkers.html#security-insecureapi-strcpy-c Label : clang-tidy Type: Enhancement

Contributor guide

Research direction
Locate the source file in clang analyzer that defines the list of unsafe strcpy functions (e.g., in `clang/lib/StaticAnalyzer/Checkers/`) and add the requested functions to the appropriate list. Also ensure to handle platform specific functions like Windows/ATL.
Tech stack
ccpp
Domain
security
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70