ljharb/qs

square brackets confuse the parser

Open

#513 opened on Oct 10, 2024

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)JavaScript (911 forks)batch import
bughelp wantedparsestringify

Repository metrics

Stars
 (8,943 stars)
PR merge metrics
 (PR metrics pending)

Description

Hello, while parsing a body like the following, qs fails:

buttons[commands.identifier_orders_merge_action|{"orders":["47441","47440"]}]=Unisci+ordini

This becomes something like:

'buttons[commands.identifier_orders_merge_action|{"orders":': { '"47441","47440"': 'Unisci ordini' }

while it should be something more similar to this:

'buttons[commands.identifier_orders_merge_action|{"orders":{ '"47441","47440"}]': 'Unisci ordini'

Contributor guide

Research direction
Examine the parseKeys function in the library to understand how brackets are handled and trace the logic for extracting keys and values when nested brackets contain JSON like syntax.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50