ljharb/qs

square brackets confuse the parser

Open

#513 opened on Oct 10, 2024

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (8,015 stars) (744 forks)batch import
bughelp wantedparsestringify

Description

Hello, while parsing a body like the following, qs fails:

buttons[commands.identifier_orders_merge_action|{"orders":["47441","47440"]}]=Unisci+ordini

This becomes something like:

'buttons[commands.identifier_orders_merge_action|{"orders":': { '"47441","47440"': 'Unisci ordini' }

while it should be something more similar to this:

'buttons[commands.identifier_orders_merge_action|{"orders":{ '"47441","47440"}]': 'Unisci ordini'

Contributor guide

Tech stack
javascript
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the parsing logic in the qs library, likely in the `lib/parse.js` file, to understand how square brackets and nested JSON strings are tokenized. Look for existing tests related to bracket parsing and consider adding a test case that reproduces the issue with a query string containing JSON with brackets. The fix may involve adjusting the regex or the state machine that identifies keys and values. Review any linked issues or comments for additional context.