ljharb/qs

qs.stringify(json) and qs.parse(json) Results are inconsistent with expectations

Open

#471 opened on May 5, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (8,015 stars) (744 forks)batch import
bughelp wanted

Description

When my json is like this

[
    {
        "fansUid": "",
        "masterShopId": 0,
        "items": [
            {
                "itemId": "",
                "skus": [
                    {
                        "price": 0,
                        "skuId": 0,
                        "promotionToolCode": ""
                    }
                ]
            }
        ],
        "scene": ""
    }
]

i use qs.stringify(json) and qs.parse(json) . but result is

[
    {
        "fansUid": "",
        "masterShopId": "0",
        "items": [
            {
                "itemId": "",
                "skus": [
                    {
                        "[price]": "0",
                        "[skuId]": "0",
                        "[promotionToolCode]": ""
                    }
                ]
            }
        ],
        "scene": ""
    }
]

It was obvious that this was a mistake. How should I solve it

I tried to change multiple versions as well, but the latest version still did not fix the problem.

Contributor guide

Tech stack
javascript
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue involves inconsistency between qs.stringify and qs.parse with nested arrays and objects containing numeric values. Investigate the source files lib/stringify.js and lib/parse.js, focusing on how the library handles array indices and type coercion. Check the test suite for similar test cases to understand expected behavior. The comments on the issue may provide additional clues from other users.