ljharb/qs

Array of objects not parsed correctly

Open

#252 opened on Mar 1, 2018

View on GitHub
 (14 comments) (3 reactions) (0 assignees)JavaScript (8,015 stars) (744 forks)batch import
help wantedparsequestionstringify

Description

When parsing the URL ?param[][id]=5a53336d48ad1c6cba0e6ae8&param[][id]=5a53336d48ad1c6cba0e6ae7 I get

param: [{ id: ['5a53336d48ad1c6cba0e6ae8', '5a53336d48ad1c6cba0e6ae7'] }]

instead of

param: [ { id: '5a53336d48ad1c6cba0e6ae8' }, { id: '5a53336d48ad1c6cba0e6ae7' } ]

I am parsing as qs.parse(queryString, { arrayLimit: 50, ignoreQueryPrefix: true }).

Am I missing something?

Contributor guide

Tech stack
javascript
Domain
api
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptunderstanding of URL query stringsfamiliarity with qs library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Examine the `qs.parse` function in `lib/parse.js` to understand how it handles array notation with empty brackets. Check the option handling for `arrayLimit` and `ignoreQueryPrefix`. Review the 14 comments for any maintainer input or proposed solutions. Consider if a new option or fix is needed to parse `param[][id]` as an array of objects with single keys.