ljharb/qs

Array of objects not parsed correctly

Open

#252 opened on Mar 1, 2018

View on GitHubContributor guide
 (14 comments) (3 reactions) (0 assignees)JavaScript (911 forks)batch import
help wantedparsequestionstringify

Repository metrics

Stars
 (8,943 stars)
PR merge metrics
 (PR metrics pending)

Description

When parsing the URL ?param[][id]=5a53336d48ad1c6cba0e6ae8&param[][id]=5a53336d48ad1c6cba0e6ae7 I get

param: [{ id: ['5a53336d48ad1c6cba0e6ae8', '5a53336d48ad1c6cba0e6ae7'] }]

instead of

param: [ { id: '5a53336d48ad1c6cba0e6ae8' }, { id: '5a53336d48ad1c6cba0e6ae7' } ]

I am parsing as qs.parse(queryString, { arrayLimit: 50, ignoreQueryPrefix: true }).

Am I missing something?

Contributor guide

Research direction
Investigate how qs parses array like parameters and identify where the logic incorrectly merges objects.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65