ljharb/qs

Cannot parse array of objects using arrayFormat = 'brackets'

Open

#215 opened on Jun 13, 2017

View on GitHub
 (13 comments) (11 reactions) (0 assignees)JavaScript (8,015 stars) (744 forks)batch import
bughelp wantedparse

Description

The README states:

You can also create arrays of objects:

var arraysOfObjects = qs.parse('a[][b]=c');
assert.deepEqual(arraysOfObjects, { a: [{ b: 'c' }] });

However when you try to parse an array with 2 objects, an object with 2 keys is created instead:

var arraysOfObjects = qs.parse('a[][b]=c&a[][d]=e');
assert.deepEqual(arraysOfObjects, { a: [{ b: 'c' , d: 'e'}] });

This also happens with arrayFormat = 'repeat'.

If arrays without indices cannot be supported, may the allowDots option could affect arrays instead: (a.0.b=c&a.1.d=e)

Contributor guide

Tech stack
javascriptnodejs
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptBasic knowledge of query string formats
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
The issue requires modifying the parsing logic in the qs library, likely in 'lib/parse.js', to correctly handle arrays of objects when using 'brackets' or 'repeat' arrayFormat. The current behavior combines multiple objects into one; it should create separate objects. Consider the proposed use of allowDots as an alternative. Review the issue comments for additional context and any suggested fixes.