ljharb/qs

Object with array containing object and scalars is not parsed correctly.

Open

#197 opened on Feb 9, 2017

View on GitHub
 (7 comments) (0 reactions) (1 assignee)JavaScript (8,015 stars) (744 forks)batch import
bughelp wantedparse

Description

Client request from any browser $.get('/ajax', {arr: [{foo: 123, bar: 'foo'},2,3] }, ...

On server (node .10, 4.x and 7.x) with latest qs

is parsed as

{ arr: { __0: [{ foo: 123, bar: 'foo', 2: true}, 3] } }

it should be

{ arr: [ {foo: 123, bar: 'foo'}, 2, 3 ] }

Contributor guide

Tech stack
javascriptnodejs
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptunderstanding of query string parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Look at the qs source code, specifically the parse function in lib/parse.js. The issue involves array parsing with mixed object and scalar values. The current behavior creates an object with numeric keys instead of an array. Check if there is a test file for this case (e.g., test/parse.js). The discussion in the issue suggests that the fix may involve handling array indices correctly when the array contains both objects and primitives. Review any linked PRs or comments for potential solutions.