ljharb/qs

RFC 3986 reserved characters missing

Open

#163 opened on May 10, 2016

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)JavaScript (911 forks)batch import
bughelp wantedstringify

Repository metrics

Stars
 (8,943 stars)
PR merge metrics
 (PR metrics pending)

Description

stringify is supposed to be implementing RFC 3986 but RFC 3986 specifies reserved characters as:

reserved    = gen-delims / sub-delims
gen-delims  = ":" / "/" / "?" / "#" / "[" / "]" / "@"
sub-delims  = "!" / "$" / "&" / "'" / "(" / ")"
                  / "*" / "+" / "," / ";" / "="

However $ (as pointed out in request#2129) will be encoded as %24. I guess this is a bug?

Contributor guide

Research direction
Examine the stringify function in lib/utils.js to see how reserved characters are handled. Compare with RFC 3986 list and fix encoding for missing characters like $.
Tech stack
javascript
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70