ljharb/qs

RFC 3986 reserved characters missing

Open

#163 opened on May 10, 2016

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (8,015 stars) (744 forks)batch import
bughelp wantedstringify

Description

stringify is supposed to be implementing RFC 3986 but RFC 3986 specifies reserved characters as:

reserved    = gen-delims / sub-delims
gen-delims  = ":" / "/" / "?" / "#" / "[" / "]" / "@"
sub-delims  = "!" / "$" / "&" / "'" / "(" / ")"
                  / "*" / "+" / "," / ";" / "="

However $ (as pointed out in request#2129) will be encoded as %24. I guess this is a bug?

Contributor guide

Tech stack
javascript
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
understanding of RFC 3986basic JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate lib/utils.js line 70 to see the current reserved character list in the stringify function. Compare with RFC 3986 section 2.2 to identify missing characters like '$'. Add the missing characters to the regex or condition, then run the test suite and add new test cases for '$' and other missing characters.