Does not work with builtin objects with internal slots (URL, Map, Set, etc)

Repository metrics

Stars

61 stars (61 stars)

PR merge metrics

PR metrics pending (PR metrics pending)

Description

    traverse({ url: new URL("https://example.com") }).map(function () {
      if (this.node instanceof URL) {
        this.update(this.node.toString());
      }
    });

TypeError: Receiver must be an instance of class URL
 ❯ Object.<anonymous> src/log-sanitizer.spec.ts:57:31
     55|     traverse({ url: new URL("https://example.com") }).map(function () {
     56|       if (this.node instanceof URL) {
     57|         this.update(this.node.toString());
       |                               ^
     58|       }
     59|     });
 ❯ walker node_modules/traverse/index.js:169:16
 ❯ node_modules/traverse/index.js:190:17
 ❯ forEach node_modules/traverse/index.js:19:30
 ❯ walker node_modules/traverse/index.js:185:4
 ❯ walk node_modules/traverse/index.js:208:3
 ❯ Traverse.map node_modules/traverse/index.js:251:9

Contributor guide

Research direction

Investigate why the traverse library fails on built in objects with internal slots (e.g., URL, Map, Set). Likely the update method attempts to set a property on the object directly, which triggers a TypeError because internal slots cannot be set via assignment. Consider using Object.getOwnPropertyDescriptor and Object.defineProperty to handle these cases, or check for such objects and skip or clone them appropriately.

Tech stack

javascript

Domain

developer experience

Issue type

Bug

DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.

2

Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.

1-3 hours

Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.

Active

ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.

Clear

Prerequisites

JavaScriptNode.js

Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.

60