ljharb/can-merge

can-merge incorrectly says the PR is mergeable

Open

#38 opened on Dec 27, 2021

View on GitHub
 (6 comments) (1 reaction) (2 assignees)JavaScript (3 forks)github user discovery
buggood first issuehelp wanted

Repository metrics

Stars
 (15 stars)
PR merge metrics
 (PR metrics pending)

Description

On https://github.com/nvm-sh/nvm/pull/2698, at a stage when every status check was green except for the Travis CI one, which was pending, I got this output:

$ can-merge --remote=source --pr=2698
PR status: 2698 ✔ This PR is mergeable
Pending Checks (1): Travis CI - Pull Request

It shouldn't report that the PR is mergeable while there's still a pending required check (since the travis check is required). Note that this output would have been perfect if travis was optional.

Note that the exit code was 1, which is correct.

Contributor guide

Research direction
Investigate the logic that determines mergeability, specifically how it handles pending required checks.
Tech stack
javascriptnodejs
Domain
clidevops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70