Convert the javascript code to typescript

Open
#569 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript, typescript
Domain
testing-qa

Research direction

Start by reviewing the protocol tests and the approach proposed in issue 568 for shared behaviors. Identify which JavaScript test suites can adopt shared TypeScript behaviors first, then verify that existing logic and tests continue to pass after each migration step.

Written by the indexing model from the issue text.

Description

Context
A lot of the protocol tests are implemented in javascript, which is very error-prone - especially when it comes to its lack of type safety.

Proposal
I think that moving from javascript to typescript might be worth the effort. The priority, however, should be not to break any of the existing logic/tests. One way we could gradually tackle the javascript<>typescript refactoring might be related to https://github.com/livepeer/protocol/issues/568, whereby we could start writing the shared behaviors of the tests in typescript right away and then 'plug them in' the existing test suites & replace the javascript parts

Dominant language
JavaScript
Stars
155
Forks
50
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from livepeer/protocol

All issues in livepeer/protocol

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.