Move repeating contract getters to base contract

Open
#563 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
solidity
Domain
blockchain

Research direction

Start by comparing the getter declarations in contracts/bonding/BondingManager.sol, contracts/rounds/RoundsManager.sol, and contracts/pm/mixins/MixinContractRegistry.sol. Identify the declarations shared across these protocol contracts and determine the appropriate base contract for them. Done means the repeated declarations are provided through that shared base without breaking contract compilation or behavior.

Written by the indexing model from the issue text.

Description

discussion enhancement

The declarations of some getter functions is repeated across various protocol contracts (i.e.: here, here and here).
I suggest to move it to a shared base contract to keep the codebase more DRY

Dominant language
JavaScript
Stars
155
Forks
50
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from livepeer/protocol

All issues in livepeer/protocol

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.