livepeer/go-livepeer

running `-nvidia=0` with `-testTranscoder=false` results in an O with no capabilities

Open

#2,450 opened on Jun 7, 2022

View on GitHubContributor guide
 (1 comment) (0 reactions) (1 assignee)Go (223 forks)auto 404
area: orchestrator QoLgood first issuehacktoberfest

Repository metrics

Stars
 (583 stars)
PR merge metrics
 (PR metrics pending)

Description

Once upon a time you had to run -testTranscoder false if you were going to use Nvidia transcoding on Windows. That appears to have been fixed, hooray!

But I did it anyway:

./livepeer.exe -orchestrator true -transcoder true \
  -network offchain -serviceAddr 192.168.0.49:8935 \
  -nvidia 0 -v 9 -testTranscoder false

and it results in a completely useless O: it reports that it has zero capabilities to do anything whatsoever; Bs will always pass it over during the discovery process. No obvious reason for such a thing to be running at all — I guess it could make reward calls or something.

Minimally we should print a log line for this or crash entirely. But perhaps it's time to remove the testTranscoder flag entirely if it's not useful anymore?

Contributor guide

Research direction
Investigate the handling of the ` testTranscoder` flag in the orchestrator code. Determine if the flag can be safely removed or if a warning should be printed when combined with ` nvidia`. If removing, ensure no side effects.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75