livepeer/go-livepeer

livepeer_cli for Broadcaster: "Error getting status" on startup and when calling "Get node status"

Open

#2,186 opened on Jan 16, 2022

View on GitHubContributor guide
 (1 comment) (0 reactions) (1 assignee)Go (223 forks)auto 404
area: cligood first issuehacktoberfesthelp wantedtype: bug

Repository metrics

Stars
 (583 stars)
PR merge metrics
 (PR metrics pending)

Description

Summary

When using the livepeer_cli to configure a Broadcaster, the following message is displayed in the cli UI on a) startup, and b) calling 1. Get node status:

ERROR: logging before flag.Parse: E0116 11:52:21.005601    6268 wizard_stats.go:28] Error getting status:json: cannot unmarshal string into Go struct field OrchestratorLocalInfo.OrchestratorPoolInfos.Url of type url.URL

To Reproduce

Steps to reproduce the behavior:

  1. Run livepeer in -broadcaster mode with the following command (for completeness):
./livepeer -broadcaster \
        -network rinkeby \
        -ethUrl https://rinkeby.infura.io/v3/888a...243d \
        -pixelsPerUnit 1
  1. Observe the aforementioned error message being displayed (see screenshot)
  2. Run option 1. Get node status
  3. Observe the aforementioned error message being displayed (see screenshot)

Expected behavior

I expect the livepeer_cli to not display unnecessary error message, in order to give new Broadcasters a feeling that the software is robust and mature for their usage.

Environment

  • Ubuntu 20.04.3 LTS
  • livepeer 0.5.25

Screenshots:

On starting up the cli:

image

On calling 1. Get node status

image

Contributor guide

Research direction
Investigate the JSON unmarshalling in wizard stats.go at line 28 where OrchestratorPoolInfos.Url is expected to be url.URL but receives a string. Modify the struct or implement custom unmarshalling to handle the string conversion.
Tech stack
go
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75