livepeer/go-livepeer

livepeer_cli: Prompt for rewardCut/feeShare shows a default value but pressing enter uses the current value

Open

#1,836 opened on Apr 9, 2021

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Go (223 forks)auto 404
area: cligood first issuetype: bug

Repository metrics

Stars
 (583 stars)
PR merge metrics
 (PR metrics pending)

Description

It is reasonable to assume that if a default value is shown in the prompt that that would be the value used if no value is explicitly provided. However, this is not the current behavior - the current behavior is to use the current value if no value is specified even though the prompt indicates a default.

The fix here should be to line up the behavior when no value is specified with what a user would expect to avoid the scenario where the user provides no value expecting to use the default only to set the rewardCut + feeShare to 0 (the current uninitialized values) [1]. How to accomplish this is left TBD for the implementer.

[1] At least one user reported that this happened to them.

Contributor guide

Research direction
Investigate the prompt implementation in livepeer cli to make the default value used when no input is provided.
Tech stack
go
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80