livebud/bud

generated app directory fails linting with golangci-lint

Open

#331 opened on Nov 27, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (211 forks)batch import
help wanted

Repository metrics

Stars
 (5,391 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

golangci-lint run --fix
bud/internal/app/main.go:74:19: Error return value of `budClient.Publish` is not checked (errcheck)
	budClient.Publish("app:ready", nil)

As part of CI I run a linting of my repository. I suggest adding the line //nolint at the top of the template for bud/internal/app/main.go, as well as any other bud-managed template boilerplate files. This way any linters people use will ignore these files (without having to do special configuration to exclude the bud directory like is already automagically done in the .gitignore.)

Contributor guide

Research direction
Add a //nolint comment to the generated template file bud/internal/app/main.go to suppress the errcheck lint error.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85