litmuschaos/litmus

Chore: remove inefficient code

Open

#4206 opened on Oct 4, 2023

View on GitHub
 (6 comments) (0 reactions) (1 assignee)HTML (3,702 stars) (574 forks)batch import
Hacktoberfestgood first issue

Description

As you can see in the switch expression, lastExperimentRunStatus === ExperimentRunStatus.RUNNING and lastExperimentRunStatus === ExperimentRunStatus.QUEUED are always true. IMO, we can shift these statements to true

Anyone who finds good first issues or participates in hacktoberfest can take this issue.

https://github.com/litmuschaos/litmus/blob/794676f6b75e08835334fd5d675e0b0d096d5f9d/chaoscenter/web/src/views/ExperimentDashboardV2/ExperimentDashboardV2Table.tsx#L207-L223

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic TypeScript knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine the switch expression in ExperimentDashboardV2Table.tsx lines 207-223. Identify conditions that are always true (e.g., `lastExperimentRunStatus === ExperimentRunStatus.RUNNING` and `QUEUED`). Replace those conditions with `true` and remove the redundant checks. Ensure the logic remains correct.