litestar-org/litestar

Enhancement: Rate Limit Config

Open

#1,262 opened on Mar 3, 2023

View on GitHub
 (14 comments) (1 reaction) (0 assignees)Python (8,243 stars) (550 forks)user submission
EnhancementGood First IssueHelp Wanted :sos:Middleware

Description

About class starlite.middleware.rate_limit.RateLimitConfig

this， rate_limit: Tuple[Literal['second', 'minute', 'hour', 'day'], int]

A tuple containing a time unit (second, minute, hour, day) and quantity, e.g. (“day”, 100) or (“minute”, 5) could be changed to [ (“day”, 100) ,(“minute”, 5),("second",1)]?

Contributor guide

Tech stack
python
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python type hintsrate limiting conceptsLitestar middleware
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look at the `RateLimitConfig` class in the rate limit middleware module. The type hint for `rate limit` needs to be changed from a single tuple to a list of tuples, and the corresponding logic for applying multiple rate limits should be updated. Review the discussion in the comments for any maintainer guidance on implementation approach.