[BUG] TMPDIR not quoted in init-plex-chown/run script
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 92/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- docker, shell
- Domain
- devops, infrastructure
Research direction
Open root/etc/s6-overlay/s6-rc.d/init-plex-chown/run and compare the unquoted TMPDIR use on line 8 with the quoted use on line 6. Verify the script with a TMPDIR path containing spaces; done means mkdir handles that path correctly without creating incorrect directories.
Written by the indexing model from the issue text.
Description
Current Behavior
In root/etc/s6-overlay/s6-rc.d/init-plex-chown/run, line 8 uses mkdir -p ${TMPDIR} without quoting the variable. While the default value (/run/plex-temp) doesn't contain spaces, if a user sets TMPDIR to a path with spaces, the mkdir command will fail or create the wrong directory.
Expected Behavior
TMPDIR should be quoted consistently, like it is on line 6 where rm -rf "${TMPDIR}" is used.
Steps To Reproduce
- Set
TMPDIR=/path with spaces/plex-tempin docker create/run command - Start the container
- The
mkdir -pcommand will fail or create incorrect directories
Environment
- OS: Any
- How docker service was installed: Any
- CPU architecture: x86-64 or arm64
- Docker creation: Any docker create/run command with TMPDIR containing spaces
Container logs
N/A - this is a code quality issue
- Dominant language
- Dockerfile
- Stars
- 1.4k
- Forks
- 228
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from linuxserver/docker-plex
-
invalid no-issue-activity
Difficulty 3/5 1-2 days Newbie friendliness 45/100
linuxserver/docker-plex#457 · 3 comments ·
-
work-in-progress
Difficulty 4/5 3-5 days Newbie friendliness 35/100
linuxserver/docker-plex#432 · 27 comments ·
All issues in linuxserver/docker-plex
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·
-
repo:raw-data
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
hotosm/raw-data-api#316 · 1 comment ·
-
agentic-workflows cascade-suspected
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
willow
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
openedx/openedx-authz#460 ·