[FEAT] Add in a build step to pull in the new p2p binary

Open
#38 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
dockerfile
Domain
build-system

Research direction

Start by reviewing pull request #37 and the existing script that downloads the p2p binary after server startup. The change is complete when the binary is pulled during the image build so environments that block runtime downloads can still use the p2p feature.

Written by the indexing model from the issue text.

Description

enhancement
Is this a new feature request?
  • I have searched the existing issues
Wanted change

mStream uses a binary for it's p2p feature (the binary is built and hosted in a repo I own). Right now there is a script that downloads the binary after booting up the server, but some environments block it from being downloaded. I have made PR that makes this build change:

https://github.com/linuxserver/docker-mstream/pull/37

Reason for change

See above

Proposed code change

See the PR

Dominant language
Dockerfile
Stars
88
Forks
16
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Similar issues

More Build System issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.