[code] Shadow variable and possible memory leak
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Read src/xviewer-list-store.c around line 381 and lines 413-420, then check the GTK ownership rules relevant to image. Confirm whether the inner variable shadows the earlier one and whether g_object_unref(image) is required. Done means the shadowing and reference-counting behavior are verified and the appropriate correction is made.
Written by the indexing model from the issue text.
Description
I don't know much about GTK, if someone can check this, thanks.
The variable image hides a superior. Also verify the need to call g_object_unref (image)
Maybe the intention was to use this variable, L381
https://github.com/linuxmint/xviewer/blob/b8cc32f70b96a523ea35bc06166aa672dab84ffa/src/xviewer-list-store.c#L381
- Dominant language
- C
- Stars
- 92
- Forks
- 47
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from linuxmint/xviewer
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
Difficulty 3/5 1-2 days Newbie friendliness 64/100
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
All issues in linuxmint/xviewer
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
level/task module/gcp type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
hapostgres/pg_auto_failover#1190 ·
-
docs
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
P3 sonic-vpp
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
sonic-net/sonic-buildimage#29662 ·