For already viewed images rotation is not changed when `Automatic Orientation` is changed in preferences

Open
#189 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
c
Domain
desktop

Research direction

Reproduce the issue with images containing an EXIF Orientation tag, following the listed steps in Xviewer 3.4.1 on Mint 21.1. Start by tracing the EXIF data and rotation handling described in the report; the fix is complete when changing Automatic Orientation also updates images that were already viewed.

Written by the indexing model from the issue text.

Description

 * Xviewer 3.4.1
 * Distribution - (Mint 21.1)

Issue

Automatic Orientation in preferences affects only newly viewed images.
Other preferences, e.g. Smoothing affect both new and already viewed images. So there is no consistency.

Steps to reproduce

Open folder with images containing "Orientation" tag in exif. View one, move to another. Change Automatic Orientation in preferences. Move back to 1st image.

Expected behaviour

Image rotated (or not) in accordance with just set preference.

Actual behaviour

Image rotation is same as when initially viewed.

Other information

I've tried to look at the code. My current understanding is that EXIF data and rotation are stored in each loaded image and not changed afterwords, there is a code for that in the project. I could not find similar code for Smoothing, seems to me it is done by some library xviewer relies upon.

Dominant language
C
Stars
92
Forks
47
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from linuxmint/xviewer

All issues in linuxmint/xviewer

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.