Failing to save with invalid encoding, "Retry" button is useless and breaks program/UI

Open
#682 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
c
Domain
desktop

Research direction

Start by reproducing the save failure with an ASCII-encoded document containing a Unicode character, then trace the error dialog's Retry and Cancel handling. Confirm that after Retry the document remains editable, Undo works, and the document can be closed without terminating xed.

Written by the indexing model from the issue text.

Description

Steps to repro:

  1. Create ascii text file ("Western" encoding)
  2. Enter Unicode character
  3. Attempt to save

Error box appears with buttons "Retry" and "Cancel". The document, at this point, is unable to be edited.

  1. Click "Retry" (with or without changing encoding drop-down)

Result:
Error box closes. Document remains unable to be edited. "Undo" is inoperative. Document is unable to be closed without closing xed completely and choosing "Close without Saving" from error dialog.

Expected:
Document would be able to be edited when encoding error box appears. "Retry" button would not destroy usability of the app.

This question was never answered:

https://stackoverflow.com/questions/36252061/where-is-the-character-encoding-of-a-text-file-stored-in-linux

EDIT: Nevermind, I guess you guys are using ~/.local/share/gedit/gedit-metadata.xml ?

Regardless, this is still a bug in xed when UI elements are unresponsive.

Dominant language
C
Stars
551
Forks
115
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from linuxmint/xed

All issues in linuxmint/xed

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.