Mint-Y: Gtk.Separator contarst / parameterization

Open Beginner friendly
#482 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
scss
Domain
design, desktop

Research direction

Start with the separator rules in src/Mint-Y/gtk-3.0/sass/_common.scss around lines 2431-2436 and src/Mint-Y/gtk-4.0/sass/_common.scss around lines 2642-2647. Read how $separator_color is defined and used, then apply the proposed parameterization in both files. Done means Mint-Y dark separators use the parameterized color with improved contrast.

Written by the indexing model from the issue text.

Description

It would be nice to increase the Gtk.Separator contrast in the Mint-Y dark version. In addition, I noticed that the separators' color is not parameterized.

Currently, the separators look like:

Screenshot from 2024-11-08 22-21-19

Solution

It would be possible to parametrize background-color with the $separator_color variable.

 //vbox and hbox separators 
 separator { 
   background-color: $separator_color;
   min-width: 1px; 
   min-height: 1px; 
 }

https://github.com/linuxmint/mint-themes/blob/5de93c0c55b98526e90e087afdcb2a4bb78d3070/src/Mint-Y/gtk-3.0/sass/_common.scss#L2431-L2436

https://github.com/linuxmint/mint-themes/blob/5de93c0c55b98526e90e087afdcb2a4bb78d3070/src/Mint-Y/gtk-4.0/sass/_common.scss#L2642-L2647

Print Screen after making changes:

Screenshot from 2024-11-08 22-23-50

Dominant language
CSS
Stars
265
Forks
137
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from linuxmint/mint-themes

All issues in linuxmint/mint-themes

Similar issues

More Design issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.