Update downstream backported patches for TPM GPIO locking
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- linux
- Domain
- embedded-iot, security
Research direction
Start by comparing coreboot reviews 90885 and 95545 to understand the corrected GPIO offsets and locking method. Update the downstream forks and AlderLake patchtrain, then test against nv4xadl. Done includes updating tpm-gpio-fail and the documentation, with the TODO items completed.
Written by the indexing model from the issue text.
Description
Skylake+ and possibly other platforms (t480*)
From discussion on coreboot matrix thread
Turns out the PCH-H datasheets are just wrong and the pad_cfg_lock_offset value for GPIO community 0 was wrong. I fixed it to match edk2-platforms and the Linux pin-ctrl driver and locking seems to be working with my original patch, though with the SBI method instead of the PCR method: https://review.coreboot.org/c/coreboot/+/90885
I will push some patches later
Locking them in SMM as is done in the patch train of https://review.coreboot.org/c/coreboot/+/95545 does not appear to be working on Skylake even with the corrected offsets.
AlderLake
Also patchtrain for alderlake (nv4x_adl), would needs backporting https://review.coreboot.org/q/topic:%22tpm_gpio_pltrst_lock%22 to be applied downstream until next release of Dasahro+Heads
Referred from https://github.com/Dasharo/coreboot/pull/959#issuecomment-5717812006
TODO
- update downstream forks used patchtrains
- test against nv4xadl
- update https://github.com/tlaurion/tpm-gpio-fail
- update docs
- Dominant language
- Makefile
- Stars
- 1.6k
- Forks
- 211
- Avg merge
- 3d 19h
- Merged PRs (30d)
- 5
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from linuxboot/heads
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
-
help wanted security SMM upstream
Difficulty 5/5 Over a week Newbie friendliness 25/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
boards: microchip: pic32cz_ca80_cult and pic32cz_ca90_cult give DMAC channel 3 to two peripherals Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
zephyrproject-rtos/zephyr#119843 ·
-
new device support
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Koenkk/zigbee2mqtt#33176 · 1 comment ·
-
status:needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PX4/PX4-Autopilot#28776 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100