linkedin/cruise-control

cgroups v2 support

Open

#1,873 opened on Aug 2, 2022

View on GitHub
 (5 comments) (2 reactions) (0 assignees)Java (649 forks)auto 404
functionalitygood first issue

Repository metrics

Stars
 (3,036 stars)
PR merge metrics
 (PR metrics pending)

Description

Ubuntu 22.04 uses cgroups v2 which has a different file layout from cgroups v1. This leads to an exception when cruise.control.metrics.reporter.kubernetes.mode is set to true:

[2022-08-02 11:58:20,825] WARN Failed to send Cruise Control metric [TOPIC_METRIC,TOPIC_PRODUCE_REQUEST_RATE,time=1659441495306,brokerId=0,topic=__consumer_offsets,value=0.141] (com.linkedin.kafka.cruisecontrol.metricsreporter.CruiseControlMetricsReporter)
[2022-08-02 11:59:15,327] ERROR Got exception in Cruise Control metrics reporter (com.linkedin.kafka.cruisecontrol.metricsreporter.CruiseControlMetricsReporter)
java.io.FileNotFoundException: /sys/fs/cgroup/cpu/cpu.cfs_quota_us (No such file or directory)

Don't know if it's worth fixing or it should be just documented/deprecated/removed. Java cgroup v2 support was added in recent versions (https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8230305) and reporting should work correctly without kubernetes.mode.

Contributor guide

Research direction
Investigate cgroups v2 filesystem layout in /sys/fs/cgroup/ and determine how to detect cgroup version. Modify the code to read from the correct path (e.g., /sys/fs/cgroup/cpu.max for v2) instead of /sys/fs/cgroup/cpu/cpu.cfs quota us.
Tech stack
java
Domain
backendinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaLinux cgroups
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60