linera-io/linera-protocol

Split `test_simple_user_operation` unit test into smaller unit tests

Open

#1484 opened on Jan 12, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (32,149 stars) (2,354 forks)batch import
good first issuerefactortesting

Description

Motivation

The test_simple_user_operation is an integration test that covers a few different functionalities, like:

  • Handling an operation
  • Forwarding authentication
  • Using the runtime storage
  • Performing a cross-application call
  • Using a session
  • Performing a query

Partly this was because it relied on a custom TestApplication type before #1482 was merged replacing it with a more customizable MockApplication. With the MockApplication it is now possible to split the test into simpler tests that are more like unit tests, which would help with regressions by making it simpler to isolate the issues.

Proposal

Split the test into a few smaller tests. One suggestion is to have at least:

  • a test for handling an operation that uses the runtime storage
  • a test that performs a query
  • a test that performs a cross-application call
  • a test to ensure authentication is forwarded correctly

New tests can also be added, like for example:

  • a test that performs a cross-application query
  • a test that calls a session more than once

Contributor guide

Tech stack
rust
Domain
testing
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust testing experienceKnowledge of linera execution test framework
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Examine the `test simple user operation` function in `linera execution/tests/test execution.rs`. Identify the distinct functionalities listed in the proposal (handling operation, authentication forwarding, runtime storage, cross application call, session, query). Then create new test functions for each, using `MockApplication` to isolate each scenario. Ensure the new tests are placed in the same file and follow the existing test patterns.