linebender/parley

All methods on `PlainEditor` should also be available on `PlainEditorDriver`

Open

#200 opened on Dec 6, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (92 forks)github user discovery
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (620 stars)
PR merge metrics
 (PR metrics pending)

Description

The new "driver" API makes sense from an efficiency point of view. But it is super annoying that some methods are only available on PlainEditorDriver and some are only available on PlainEditor. This can be worked around by doing driver.editor., but this is an unnecessary API wart.

I can see two possibilities:

  • We manually add all methods
  • We implement Deref and DerefMut for PlainEditorDriver

Contributor guide

Research direction
Explore implementing Deref and DerefMut for PlainEditorDriver to delegate methods to PlainEditor.
Tech stack
rust
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60