linebender/druid

Mutating setters on druid_shell::Window should have `set_` names.

Open

#777 opened on Mar 30, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (567 forks)batch import
help wantedshell

Repository metrics

Stars
 (9,091 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

At least including set_resizeable, and set_show_titlebar, although the latter name isn't great. I might change it to something like titlebar_is_visible and set_titlebar_is_visible or something?

Hmm must not have noticed this, but these should be called set_.

Originally posted by @cmyr in https://github.com/xi-editor/druid/pull/773

Contributor guide

Research direction
Identify all methods in druid shell::Window that mutate state but lack a set prefix, rename them using set prefix, and update all references in the codebase.
Tech stack
rust
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85