linebender/druid

Mutating setters on druid_shell::Window should have `set_` names.

Open

#777 opened on Mar 30, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (9,091 stars) (567 forks)batch import
help wantedshell

Description

At least including set_resizeable, and set_show_titlebar, although the latter name isn't great. I might change it to something like titlebar_is_visible and set_titlebar_is_visible or something?

Hmm must not have noticed this, but these should be called set_.

Originally posted by @cmyr in https://github.com/xi-editor/druid/pull/773

Contributor guide

Tech stack
rust
Domain
desktop
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Rename mutating setters in druid shell::Window to have `set ` prefix. Specifically, `set resizeable` and `set show titlebar` (or consider renaming `show titlebar` to `titlebar is visible`). Review the discussion in PR #773 for context. The changes are localized to the druid shell crate, likely in the Window struct implementation.