linebender/druid

dropped message when closing window on windows

Open

#160 opened on Sep 17, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (9,091 stars) (567 forks)batch import
help wantedshell/win

Description

Not sure how seriously to take this, but it came up in #149, and we should know what's going on here.

I tested a bit on Windows as well (but see comment inline about key event matching which I had to bodge). The good news is that it seems pretty robust; I wasn't able to trigger any crashes. But there are signs it isn't quite right yet, I get this logged:

2019-09-14 13:52:18,273 ERROR [druid_shell::windows] dropped message 0x2, hwnd=0x220034, wparam=0x0, lparam=0x0

I did a modest (not incredibly deep) pass through the rest and it seems pretty good to me. I like that it's simpler than my PR (exposing less of the internal event dispatching) while also adding the Command abstraction. Basically I'm comfortable with this going in soon, seems like the major issue is stability around window lifetimes. Do we want to debug and fix that in this PR, or get the API in place and treat it as a separate bug?

Contributor guide

Tech stack
rust
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustWindows API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the dropped message (0x2) in the Windows event handling code in druid shell/src/platform/windows/. The error message is logged from druid shell::windows. Look at the window message processing loop, particularly around WM DESTROY or WM CLOSE. Check PR #149 for context. Determine if it's a race condition or missing message handling.