linebender/druid

File Open dialog issue

Open

#115 opened on Aug 9, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (567 forks)batch import
bughelp wanted

Repository metrics

Stars
 (9,091 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I'm having issues combining File Open dialogs and timers in the druid-shell hello example.

Currently File Open dialogs block while holding a mutable borrow on the WinHandler until the dialog comes back with a result path. If a timer event triggers while the dialog is open, it panics with "already borrowed".

#95 mentions a possible solution. Are there other solutions to consider?

As a workaround for now I don't block when opening the dialog, immediately returning an Err(Error:Null) in get_file_dialog_path and I have a closure that runs with the actual result but I'm not sure where to send it. If a solution is decided upon I can take a shot at a PR.

Contributor guide

Research direction
Look at the druid shell file dialog implementation and understand the mutable borrow conflict with timer events. Trace how `get file dialog path` holds the borrow and consider solutions like using a channel or callback.
Tech stack
rust
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustOwnership/Borrowing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65