Use `Query` type instead of `str`

Open
#16 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
api

Research direction

Start by reading centraldogma/content_service.py at the linked API and centraldogma/query.py around lines 30-45 to understand the Query type introduced by #14. Search the existing APIs for query expressions typed as str and update the relevant annotations and usage. Done means all applicable query-expression APIs use Query consistently.

Written by the indexing model from the issue text.

Description

cleanup

#14 introduced Query type. The existing APIs that use a string as a query expression need to be updated such as.
https://github.com/line/centraldogma-python/blob/6098f1afe6b181388ab32bd7f91161dd7bd2a70d/centraldogma/content_service.py#L44
https://github.com/line/centraldogma-python/blob/6098f1afe6b181388ab32bd7f91161dd7bd2a70d/centraldogma/query.py#L30-L45

Dominant language
Python
Stars
21
Forks
11
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from line/centraldogma-python

All issues in line/centraldogma-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.