Use dedicated `Revision` type instead of primitive int

Open
#15 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
api

Research direction

Start with centraldogma/dogma.py around line 140 and read centraldogma/data/revision.py lines 20-34 to understand the existing Revision type. Locate the revision values still represented as int and update the relevant uses so the client consistently exposes Revision rather than a primitive integer.

Written by the indexing model from the issue text.

Description

cleanup

Currently, a revision is represented as an int.
https://github.com/line/centraldogma-python/blob/6098f1afe6b181388ab32bd7f91161dd7bd2a70d/centraldogma/dogma.py#L140
It would be nice to use a dedicated type introduced in #14
https://github.com/line/centraldogma-python/blob/6098f1afe6b181388ab32bd7f91161dd7bd2a70d/centraldogma/data/revision.py#L20-L34

Dominant language
Python
Stars
21
Forks
11
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from line/centraldogma-python

All issues in line/centraldogma-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.