line/armeria

Consider to remove sorting at MeterIdPrefix

Closed

#2,150 opened on Oct 3, 2019

View on GitHubContributor guide
 (10 comments) (0 reactions) (0 assignees)Java (863 forks)batch import
good first issueperformance

Repository metrics

Stars
 (4,552 stars)
PR merge metrics
 (Avg merge 5d 12h) (42 merged PRs in 30d)

Description

Currently, we sort the micrometer tags at MeterIdPrefix to create Meter ID stably. https://github.com/line/armeria/blob/master/core/src/main/java/com/linecorp/armeria/common/metric/MeterIdPrefix.java#L95-L101

Since I saw this stacktrace from our service’s flamegraph, I would like to consider whether it is avoidable or not. Since it doesn’t have many samples, we can be ignored but because it is not optimal, it would be happy if we can avoid this sort.

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.