[Feature Request] Renaming Second Parameter from width to length in thumbnail operations

Open
#212 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
php
Domain
api

Research direction

Locate the *thumbnail-related methods and their documentation, then inspect how the second parameter is exposed and used. Confirm the intended naming across all affected methods and determine what compatibility considerations apply; the work is done when the naming is consistent and documented.

Written by the indexing model from the issue text.

Description

Hi,

Do you think if it would be better to rename the second parameter width to length in *thumbnail related methods?
For me, at the first glance, the name width in documents/code appears like the standard length in x axis strictly. And it misleads when the methods take higher side in consideration and create a 100x200px thumbnail for 400x800px vertical image when width = 200 is specified (with width = 200, it seems as a thumbnail with 200px length in x axis).

Thank you

Dominant language
PHP
Stars
721
Forks
33
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from libvips/php-vips

All issues in libvips/php-vips

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.