SDL2 testtimer query
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 65/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- c
- Domain
- testing-qa
Research direction
Start with test/testtimer.c around line 83 and src/test/SDL_test_common.c around line 1135, then compare the corresponding SDL3 implementation at src/test/SDL_test_common.c around line 1496. Run the SDL2 testtimer test and verify that its requested initialization flags are handled consistently with SDL3.
Written by the indexing model from the issue text.
Description
testtimer passes SDL_INIT_TIMER to test framework: https://github.com/libsdl-org/SDL/blob/SDL2/test/testtimer.c#L83
but CommonInit seems to ignore this flag https://github.com/libsdl-org/SDL/blob/SDL2/src/test/SDL_test_common.c#L1135
My question is that should SDL2 CommonInit pass flags to SDL_InitSubSystem like SDL3 does? https://github.com/libsdl-org/SDL/blob/main/src/test/SDL_test_common.c#L1496
- Dominant language
- C
- Stars
- 16.6k
- Forks
- 3k
- Avg merge
- 15h 40m
- Merged PRs (30d)
- 70
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from libsdl-org/SDL
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
libsdl-org/SDL#16360 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
libsdl-org/SDL#16220 ·
-
Flydigi Vader 5 Pro rumble does not work — rumble path missed by the unnumbered-report fix in #15594 Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
libsdl-org/SDL#16187 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
libsdl-org/SDL#16089 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
libsdl-org/SDL#16353 · 3 comments ·
Similar issues
-
level/task module/gcp type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
hapostgres/pg_auto_failover#1190 ·
-
docs
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
P3 sonic-vpp
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
sonic-net/sonic-buildimage#29662 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 94/100
spack/spack-packages#6586 ·