LRPS2 core for Apple Silicon?

Open
#91 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
52/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp, macos

Research direction

Start by reproducing the reported make failure in the repository and inspect the build configuration and 3rd-party/rapidyaml dependency path referenced by common/StringUtil.h. Then trace how the core is built for the Apple x86_64 and arm64 targets. Done means the core builds for Apple Silicon and is available from the arm64 nightly download path.

Written by the indexing model from the issue text.

Description

I was hoping that LRPS2 could be built for Apple Silicon? For whatever reason, it's Intel only:

https://buildbot.libretro.com/nightly/apple/osx/x86_64/latest/
Image

https://buildbot.libretro.com/nightly/apple/osx/arm64/latest/
Image

I needed to open RetroArch with Rosetta to even see the core as an option to download:
Image
Image

Image Image

Is there some sort of technical reason why it's x86_64 only? I tried building the source code myself but it failed/errored out

make
c++ -c -ocommon/AlignedMalloc.o common/AlignedMalloc.cpp -DGIT_VERSION=\"" b0e6c4d7f"\"  -DWANT_THREADING -DHAVE_THREADS -DFRONTEND_SUPPORTS_RGB565 -fPIC -I. -I./pcsx2 -I./3rdparty -I./3rdparty/cpuinfo/include -I./3rdparty/cpuinfo/src -I./3rdparty/cpuinfo/deps/clog/include -I./libretro/libretro-common/include -I  -Wall -Wvla -Wno-sign-compare -Wno-unused-variable -Wno-unused-function -Wno-uninitialized  -Wno-strict-aliasing  -DSTDC_HEADERS -D__STDC_LIMIT_MACROS -D__LIBRETRO__  -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -O3 -DNDEBUG -MMD -DGIT_VERSION=\"" b0e6c4d7f"\"  -DWANT_THREADING -DHAVE_THREADS -DFRONTEND_SUPPORTS_RGB565 -fPIC -I. -I./pcsx2 -I./3rdparty -I./3rdparty/cpuinfo/include -I./3rdparty/cpuinfo/src -I./3rdparty/cpuinfo/deps/clog/include -I./libretro/libretro-common/include -I  -Wall -Wvla -Wno-sign-compare -Wno-unused-variable -Wno-unused-function -Wno-uninitialized  -Wno-strict-aliasing  -DSTDC_HEADERS -D__STDC_LIMIT_MACROS -D__LIBRETRO__  -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS
c++ -c -ocommon/Console.o common/Console.cpp -DGIT_VERSION=\"" b0e6c4d7f"\"  -DWANT_THREADING -DHAVE_THREADS -DFRONTEND_SUPPORTS_RGB565 -fPIC -I. -I./pcsx2 -I./3rdparty -I./3rdparty/cpuinfo/include -I./3rdparty/cpuinfo/src -I./3rdparty/cpuinfo/deps/clog/include -I./libretro/libretro-common/include -I  -Wall -Wvla -Wno-sign-compare -Wno-unused-variable -Wno-unused-function -Wno-uninitialized  -Wno-strict-aliasing  -DSTDC_HEADERS -D__STDC_LIMIT_MACROS -D__LIBRETRO__  -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -O3 -DNDEBUG -MMD -DGIT_VERSION=\"" b0e6c4d7f"\"  -DWANT_THREADING -DHAVE_THREADS -DFRONTEND_SUPPORTS_RGB565 -fPIC -I. -I./pcsx2 -I./3rdparty -I./3rdparty/cpuinfo/include -I./3rdparty/cpuinfo/src -I./3rdparty/cpuinfo/deps/clog/include -I./libretro/libretro-common/include -I  -Wall -Wvla -Wno-sign-compare -Wno-unused-variable -Wno-unused-function -Wno-uninitialized  -Wno-strict-aliasing  -DSTDC_HEADERS -D__STDC_LIMIT_MACROS -D__LIBRETRO__  -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS
In file included from common/Console.cpp:18:
common/StringUtil.h:33:10: fatal error: '../3rdparty/rapidyaml/rapidyaml/ext/c4core/src/c4/ext/fast_float/include/fast_float/fast_float.h' file not found
   33 | #include "../3rdparty/rapidyaml/rapidyaml/ext/c4core/src/c4/ext/fast_float/include/fast_float/fast_float.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make: *** [common/Console.o] Error 1

Any help would be awesome 😀 👍🏻

Dominant language
C++
Stars
85
Forks
26
Avg merge
6h 43m
Merged PRs (30d)
6

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from libretro/ps2

All issues in libretro/ps2

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.