libre-tube/LibreTube

Video quality limited to screen resolution

Open

#4255 opened on Jul 18, 2023

View on GitHub
 (7 comments) (3 reactions) (0 assignees)Kotlin (11,863 stars) (599 forks)batch import
bughelp wantedpriority: low

Description

Steps to reproduce

  1. Open a high resolution video and switch quality to higher quality than screen resolution (for eg -if screen resolution is 720p switch to quality higher than 720p like 1080p 1440p etc)

Expected behavior

If switched to a higher quality than screen resolution, it should play it and should not cap it.

Actual behavior

It caps to quality of screen resolution like it plays only 720p according to stats on 720p screen. and sometimes it even plays 500p something in 720p screen when it should play what is selected

LibreTube version

0.16.1

Android version

Android 12 , 8.1

Other details

No response

Acknowledgements

  • I have written a short but informative title.
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I will fill out all of the requested information in this form.

Contributor guide

Tech stack
kotlinandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
KotlinAndroid development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Start by locating the video player initialization code in the repository, likely in a file like `PlayerFragment.kt` or `VideoPlayerActivity.kt`. Examine how the quality is selected and check if there is any logic that limits resolution based on screen dimensions. Look for comments or previous commits related to resolution caps. Test with a video that has resolutions higher than screen resolution to confirm the bug. Consider the ExoPlayer library used by LibreTube and how its TrackSelector is configured.