libp2p/js-peer-info

distinct wildcard addresses are conflated.

Open

#60 opened on Dec 1, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (25 forks)github user discovery
P2 - Mediumbugdifficulty:moderatehelp wantedready

Repository metrics

Stars
 (37 stars)
PR merge metrics
 (PR metrics pending)

Description

When two wildcard addresses are im the multiaddresses and they use wildcard address and port, they are deemed as the same in peerInfo.multiaddrs.distinct(), only one of them being returned.

For instance,

/ip4/0.0.0.0/tcp/0 is conflated with /ip4/0.0.0.0/tcp/0/some-other-transport because the tranport and port are the same, but really 0 here signifies "any port" and should lead to distinct addresses.

Contributor guide

Research direction
Inspect the distinct() method in multiaddr set.js (line 91-95). Determine how wildcard addresses (e.g., /ip4/0.0.0.0/tcp/0) are compared and why they are considered equal despite different transports. Modify the comparison logic to treat wildcard ports as distinct based on full multiaddress structure.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65