libp2p/js-libp2p-crypto

Ed25519 Private Key length

Open

#200 opened on Oct 7, 2021

View on GitHub
 (1 comment) (0 reactions) (1 assignee)TypeScript (49 forks)auto 404
P2good first issuehelp wantedstatus/ready

Repository metrics

Stars
 (79 stars)
PR merge metrics
 (PR metrics pending)

Description

Constructing a new Ed25519 key by passing a 32 byte Uint8Array should be allowed. I assume this check is due to the convention of passing in private & public concatenated, would be nice to detect a 32 byte key per the spec.

I could work on a pull if this is of interest to anyone else.

https://github.com/libp2p/js-libp2p-crypto/blob/a99f419f7904317271c3d0eb6f8eb31e69d3f9b5/src/keys/ed25519-class.js#L44

Contributor guide

Research direction
Inspect the validation logic in ed25519 class.js at line 44 and modify it to accept 32 byte keys as per RFC 8032 section 5.1.5. Additionally, check if any other parts of the codebase assume a 64 byte key to ensure compatibility.
Tech stack
typescript
Domain
cryptographybackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80