diff.patch returns wrong dates in Python 3.10
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
Research direction
Start at the diff.patch path that formats the displayed dates and trace how Arrow timestamps are serialized. Reproduce the output with Python 3.10 and arrow==1.2.2, then verify that diff.patch contains timestamp values rather than a bound-method representation.
Written by the indexing model from the issue text.
Description
The newest version of arrow library doesn't have timestamp property anymore, only method.
When I try to run the pygit2 with latest arrow (arrow==1.2.2) I get this in the output of diff.patch:
diff --git a/ff637b965cc54980ba5d852d662d0793 b/ff637b965cc54980ba5d852d662d0793
index d88c807..1d33f32 100644
--- a/ff637b965cc54980ba5d852d662d0793 +++ b/ff637b965cc54980ba5d852d662d0793 @@ -62,7 +62,9 @@ "content": "We should work on this",
"custom_fields": [],
"date_created": "<bound method Arrow.timestamp of <Arrow [2022-02-02T14:55:22.090307+00:00]>>",
- "depends": [],
+ "depends": [ + "3" + ], "full_url": "http://localhost.localdomain/test/issue/1",
"id": 1,
"last_updated": "<bound method Arrow.timestamp of <Arrow [2022-02-02T14:55:23.637241+00:00]>>",
As you can see there is only a reference to method instead of value.
- Dominant language
- Python
- Stars
- 1.7k
- Forks
- 408
- Avg merge
- 2d 57m
- Merged PRs (30d)
- 7
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from libgit2/pygit2
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
learningequality/ricecooker#747 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
BSData/horus-heresy-3rd-edition#3171 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
run-llama/llama_index#23199 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
KhronosGroup/glTF-Blender-IO#2769 ·