An error thrown by a custom `RpcSmartSubtransport` is consumed and not propagated to the client code

Open
#2,165 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
tooling

Research direction

Start with SmartSubtransportStream and the custom RpcSmartSubtransport read/write path described in the issue. Review the related PR #2164 and its repro test; done means the custom exception's message reaches client code and the repro test passes.

Written by the indexing model from the issue text.

Description

If implementing a custom RpcSmartSubtransport that throws an exception during the read or write operation, the error message is ignored in the SmartSubtransportStream because it is not a NativeException.

Related PR with fix and repro test: https://github.com/libgit2/libgit2sharp/pull/2164

Dominant language
C#
Stars
3.5k
Forks
925
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from libgit2/libgit2sharp

All issues in libgit2/libgit2sharp

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.