the command pull take the class Repository instead of the interface like other commands

Open
#2,091 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, git
Domain
api, backend

Research direction

Start at Commands.Pull and compare its parameter type with the other commands mentioned in the issue, especially the use of IRepository versus Repository. Reproduce the call with an IRepository on .NET 8, then verify that the pull command accepts the interface consistently with those commands.

Written by the indexing model from the issue text.

Description

Reproduction steps

try to use a IRepository as parameter to Commands.Pull
image

Expected behavior

I expect it to work

Actual behavior

I can't use the interface cause it's the class itself in the parameters
image

Version of LibGit2Sharp (release number or SHA1)

0.30.0

Operating system(s) tested; .NET runtime tested

windows 11, .NET 8

I can make the PR to change it

Dominant language
C#
Stars
3.5k
Forks
925
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from libgit2/libgit2sharp

All issues in libgit2/libgit2sharp

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.