Git Fetch fails with could not decrypt tls message when TLS 1.3 is allowed

Open
#2,089 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
csharp, git

Research direction

Start by running the reported LibGit2Sharp.Tests reproduction on Windows 10 with TLS 1.3 enabled, then trace the HTTPS fetch path that produces the “could not decrypt tls message” error. Done means the fetch completes without that error and the regression is covered by the existing test suite.

Written by the indexing model from the issue text.

Description

Reproduction steps

On windows 10 create keys "TLS 1.3\Client" under "Computer\HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols"
and two DWORDS "DisabledByDefault" with value 0 and Enabled with value 1.
image
Then create a repository and add a remote with https://github.com/libgit2/libgit2sharp.git and run a git fetch.

Expected behavior

No error fetch is executed

Actual behavior

Error "could not decrypt tls message"

Version of LibGit2Sharp (release number or SHA1)

LibGit2Sharp 0.30.0 but can also be reproduced with 0.27.2

Operating system(s) tested; .NET runtime tested

Win 10 22H2 x64 .NET 4.8

This issue can also reproduced with the LibGit2Sharp.Tests

Dominant language
C#
Stars
3.5k
Forks
925
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from libgit2/libgit2sharp

All issues in libgit2/libgit2sharp

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.