lexrus/LTMorphingLabel

Morphing animation messes up San Francisco Display font

Open

#61 opened on Jul 25, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Swift (780 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (8,150 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I really like how the colon character (:) is a little bit raised up and not touching the baseline in the San Francisco Display font introduced in WWDC 2015. Here is how it is supposed to look like:

However, once I changed the text of the label to something else with the .Fall animation, the colon dropped onto the baseline:

I believe that this is caused by the way you draw the text using Core Text. Can you fix it?

Contributor guide

Research direction
Investigate the Core Text rendering path in LTMorphingLabel, specifically how the text layout is recalculated during animation transitions. Check if the glyph positioning for the colon character is being reset to default baseline.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftUIKitCore Text
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60