lexrus/LTMorphingLabel

Crippled performance, sometimes crashing on longer strings

Open

#18 opened on Nov 13, 2014

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Swift (8,150 stars) (780 forks)batch import
bughelp wanted

Description

I've found that setting strings longer than about 50 characters crawls to a halt. Sometimes crashes. A simple fix would be to just not animate if the length is greater than a certain number. I attempted to do this by modifying the setter for the text variable, pausing the display link and setting super.text to the value if it was above a threshold. This sometimes works, but I think I'm missing something, as I still get issues with performance. Advice appreciated. Would love to use this in the next rev of Slated if I can get it reliable.

Contributor guide

Tech stack
swift
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
SwiftiOS development basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Start by examining the text property setter in LTMorphingLabel.swift and the display link logic. Look for the animation loop that processes each character. A possible fix is to add a threshold for string length and skip the morphing animation when exceeded, falling back to standard UILabel behavior. Ensure to test on longer strings to verify performance improvement.