lewster32/phaser-plugin-isometric

Types (possibly) diverged from Phaser?

Open

#42 opened on Jul 12, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (472 stars) (168 forks)batch import
help wanted

Description

My preemptive apologies if this is a silly question—I'm still a typescript/js noob.

When I try to add this plugin, I get a Typescript error:

/// <reference path="../lib/phaser.d.ts" />
/// <reference path="../lib/phaser.plugin.isometric.d.ts" />

var game = new Phaser.game(
  // game stuff
)

game.plugins.add(new Phaser.Plugin.Isometric(game));  // <- error here

The error is: "error TS2345: Argument of type 'Isometric' is not assignable to parameter of type 'PluginConstructorOf'. Type 'Isometric' provides no match for the signature 'new (...parameters: any[]): Plugin'"

I've trawled through Phaser's Plugin types and tried to hack things together to make it work but haven't had success so far, probably solely because of my own incompetence. I'm pretty sure this is the relevant section in Phaser. Any help is hugely appreciated!

Contributor guide

Tech stack
typescriptjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScript basicsPhaser plugin knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Review the TypeScript definitions in the repository, particularly the Isometric class declaration, and compare with Phaser's Plugin interface (linked in the issue). Ensure the Isometric class's constructor matches Phaser's expected signature. Consider updating the .d.ts file to use proper module augmentation or declaration merging if necessary. Also check if there are any existing PRs or fixes.