less/less.js

Remove PhantomJS stuff

Open

#3772 opened on Jan 8, 2023

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (16,977 stars) (3,517 forks)batch import
good first issueup-for-grabs

Description

I saw this and though, nobody is using phantomjs. it's a headless browser that no real user is using. it was based on webkit and the development have been discontinued. think you should remove this kind of things and instead use something like puppeteer or something.

https://github.com/less/less.js/blob/eefe33a47f6fdcc228817df7435a1770ce9e51ea/packages/less/src/less-browser/index.js#L49-L56

PhantomJS is depricated and should not be used anymore.

Contributor guide

Tech stack
javascriptnodejs
Domain
build system
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptNode.jsless.js build system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine the linked file at packages/less/src/less browser/index.js lines 49-56 to see the PhantomJS related code block. Search the entire codebase for any other references to PhantomJS. The issue suggests replacing PhantomJS with Puppeteer, but the title only says remove. Confirm with maintainers whether removal alone is sufficient or if a replacement is needed. The issue has been open for a while, so check recent comments for any updates.