leostera/warp

Honor .gitignore files

Open

#12 opened on Mar 17, 2023

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Rust (0 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (22 stars)
PR merge metrics
 (PR metrics pending)

Description

Right now some of the glob expansion that Warp does, doesn't always follow the ignored files, so sometimes we pick up files that don't end up as part of the official sources.

This happened while pairing with @diogomqbm, and we found out that there was a folder in the BEAM tricorder that had just been ignored, but locally it was being picked up by warp and building.

Edge case, but good to consider this more generally.

Contributor guide

Research direction
Examine how Warp performs glob expansion and check if it respects .gitignore rules. Focus on the glob matching logic and the file inclusion/exclusion flow.
Tech stack
rust
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60