leon-ai/leon

improve the Isitdown module

Open

#25 opened on Feb 18, 2019

View on GitHub
 (20 comments) (0 reactions) (0 assignees)TypeScript (14,041 stars) (1,186 forks)batch import
good first issueimprovementskill

Description

Expected Behavior

Be able to query the status of some website without the fully qualified domain name.

Actual Behavior

Currently a query like this fails is gitub up ? I should ask is github.com up ?

Proposal

May be list some of the most popular websites and treat them with special query as I made just before

Contributor guide

Tech stack
typescriptnodejs
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScript basicsFamiliarity with the isitdown module
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the isitdown module's query handling logic in the codebase, likely in a file like src/modules/isitdown. Identify where the input query is parsed and how the domain is extracted. Review the 20 comments on the issue for any suggested approaches or concerns. Implement a mapping of common website names (without TLD) to their full domains, such as 'github' > 'github.com', and modify the parsing to first check this mapping before treating the input as a full domain. Look at existing tests for the module to ensure the change is correctly implemented.